search

e-picsa / picsa-apps

Monorepo for building tools to support E-PICSA Apps
https://picsa.app
GNU General Public License v3.0
5 stars 1 forks source link

feat(seasonal-calendar): add translations #203

Closed khalifan-kfan closed 5 months ago

khalifan-kfan commented 7 months ago

Description

This PR is to enable translation on the seasonal calendar tool

Discussion

Building the seasonal calender

Preview

Screenshots / Videos

khalifan-kfan commented 5 months ago

Sure thanks @chrismclarke , I am going to work on this feedback

khalifan-kfan commented 5 months ago

Hello @chrismclarke, thanks for the feedback and help. All changes have been worked on.

chrismclarke commented 5 months ago

Thanks @khalifan-kfan !

I found a few minor strings without translation (e.g. some of the error messages, the months dropdown), so have updated them in efd8ad7 and ae33619

image

I also noticed it wasn't possible to translate the crop names on the table as the table essentially populates a crop id and not the label. I think probably easiest if we merge this PR here and I'll try to add a follow-up with any required data schema and binding changes. Thanks again for making the changes