e-picsa / picsa-apps

Monorepo for building tools to support E-PICSA Apps
https://picsa.app
GNU General Public License v3.0
6 stars 2 forks source link

Refactor: shared icons and data #225

Closed chrismclarke closed 8 months ago

chrismclarke commented 8 months ago

TODO

Description

Previously all tools managed their own system for storing and registering custom svg icons (e.g. crop images). This has a couple of issues as the codebase grows larger, namely duplication of assets or icon conflicts where multiple tools use the same name for different icons.

Some work has already been previously done in #224 to start the process of setting up shared registries for data and icons, this PR continues to build by registing icons with namespaces (e.g. the clear icon for use in weather is weather:clear to avoid conflict with a general clear icon which might be to remove data entry).

It also removes some of the existing duplication across crop icons, merging data so that all tools using icons have access to full lists of data

Discussion

Just to note that not all cards have been migrated to shared system. Notably budget activities are still handled separately to season calendar activities

Preview

Example - seasonal calendar tool now has access to the full list of crop options available within budget and crop probability tools localhost_4200_seasonal-calendar_ZZTPngIvCnegmAk3SFlN

Screenshots / Videos

Include at least 1-2 screenshots of videos if visual changes