search

e-picsa / picsa-apps

Monorepo for building tools to support E-PICSA Apps
https://picsa.app
GNU General Public License v3.0
5 stars 1 forks source link

Ft link search text to route navigation #235

Closed Pamella014 closed 4 months ago

Pamella014 commented 4 months ago

Description

I was able to link the search text to route navigation so that when the user leaves the search page and comes back they are able to see with a pre-built search term

Screenshots / Videos

screenshot showing the query params in the route Screenshot from 2024-02-16 09-24-08

video showing a short demonstration

Picsa Extension.webm

Include at least 1-2 screenshots of videos if visual changes

chrismclarke commented 4 months ago

Hi @Pamella014 I'm not sure quite what has happened with this PR, but somehow the branches are the wrong way round. You have requested a merge

into ft-link-search-text-to-route from main

There's no harm performing this merge as it will just update your feature branch with the latest code from main, however it does not request the changes that you have worked on to be merged into main, for that you would expect merge

into main from ft-link-search-text-to-route

I'm going to close this PR. Can you please open a new one with the code changes you have worked on instead? Looking briefly at the branch it seems that none of your updates have been applied, so you might still need to push from your local branch