e-picsa / picsa-apps

Monorepo for building tools to support E-PICSA Apps
https://picsa.app
GNU General Public License v3.0
5 stars 1 forks source link

(video-player) Playback service and storage #263

Closed OchiengPaul442 closed 2 months ago

OchiengPaul442 commented 2 months ago

Description

This PR enables view progress saving for all videos viewed within the app, so that any user can return to any video at any time, see their progress and resume playback from that position.

Video Player Service:

Discussion

Preview

Screenshots / Videos

https://github.com/e-picsa/picsa-apps/assets/97807374/c6a6e39f-ab06-4b77-8217-213e2d7c7596

chrismclarke commented 2 months ago

Hi @OchiengPaul442 - I started to take a look at this yesterday but ran out of time. All looking great, I have a few minor bits of code tidying intended which I'll just push to the branch, and I found a fix for the issue I think you picked up on for how to set the player time when starting to play for first time (requiring a small timeout) - I've also been testing on Android and have a few minor fixes to include.

If possible I'd say best to hold off on any more commits you have planned to push to the branch, as they will likely conflict with the review updates. I'll try to get them merged by the end of the day

OchiengPaul442 commented 2 months ago

Hi @chrismclarke, Thanks for the review. I’ll hold off on any further commits to the branch as requested.