e-sensing / sits

Satellite image time series in R
https://e-sensing.github.io/sitsbook/
GNU General Public License v2.0
460 stars 76 forks source link

sits_services x sits_info_services #53

Closed pedro-andrade-inpe closed 6 years ago

pedro-andrade-inpe commented 6 years ago

What is the difference between sits_services and sits_info_services?

gilbertocamara commented 6 years ago

Pedro, the function sits_info_services is not exported. You may be referring to sits_infoWTSS, in which case, the package documentation says: (a) sits_services - provides information about the time series services available (b) sits_infoWTSS - provides information about WTSS service

We envisage that SITS will provide access to different time series data provision services. Curently there are two services available: SITS from INPE and SATVEG from EMBRAPA. We plan to add other services.

It may be the case that the names of the functions are not the most appropriate. Please help us in finding better names.

pedro-andrade-inpe commented 6 years ago

sits_info_services is not exported, but it is also not used by any other function of the package:

[pedro@~/github/sits/R] $ grep sits_info_services *
sits_info.R:#' @name sits_info_services
sits_info.R:sits_info_services <- function() {
[pedro@~/github/sits/R] $ 

Could it be removed?

gilbertocamara commented 6 years ago

Point taken. I will look into the matter and come back to you.

gilbertocamara commented 6 years ago

Included sits_info_services in the export list