search

e-senturk / G531GD-GT-GU-Hackintosh

OsX build for G531-GT
22 stars 8 forks source link

G531GU Support and Guide VoodooI2C patch needed! #9

Closed trankimlonghai closed 3 years ago

trankimlonghai commented 3 years ago

Hi, it seems you made EFI OpenCore support for G531GT but non G531XX or G731 or even G512.... However, I have EFI OpenCore of G531GU, everything seems working fine (but this EFI only with AC 9560 - I plan to change to DW1560 or supported wifi card with Hackintosh but later when the warranty of my Laptop expires)

Problem is... in this EFI, VoodooI2C (Trackpad) I use patch from @williambj1 and don't know how to patch on my own, I wonder if you can support me with a guide how to patch ? I'm just confusing with this. Besides, when you need my G531GU folder EFI OpenCore to tune it and share with everyone as well as I will test with you, I will provide you a link. Hope your reply, thanks!

e-senturk commented 3 years ago

I am supporting G531GT right now probably G531GD works fine as well but higher devices has higher specs. As far as I know G531GU has better speaker and sound card and it has different configuration also touchpad might be different than my device. Creating touchpad SSDT's is not easy process and I don't have such time to do it for a distance computer right now. The guide is relatively easy for clover but in opencore you need to create seperate SSDT files and files should not interfere with other OSes. In wireless card I am supporting broadcom wifi card and I have both dw1560 and dw1820A. I recommend 1820A because its more proper card for newer versions. I am planing to support other devices as well in the feature but its just a plan right now send your efi folder and explain what's working or not. Also extract unedited DSDT and SSDT files and send them as well. I might look into it when I have enough time but no promises.

trankimlonghai commented 3 years ago

Hi, glad you replied! I understand all the suggestion you provided, thanks a lot for it But step right to the point as you need both EFI folder and untouched SSDTs and DSDTs, so now I give them to you, and just feel free, everyone has their own interests and spaces to do things in life so as you said, when you're free, you support my files for G531GU and I will test it again, no pressure. Original SSDT DSDT (BIOS ver 309 - G531GU): https://drive.google.com/file/d/1BrP5Vjc6vnqxAAzKrgVbF2Ug3SUwxmtC/view?usp=sharing

My EFI G531GU (OpenCore) folder: https://drive.google.com/file/d/12oPV2TvZ6EGDAQS8xot90bhr6cpKZJjo/view?usp=sharing What's working and what's not (base on my experiences):

Not working:

CapsLockLED not turn RED when turn Uppercase as well as Toggle left and right arrow keys to switch effect not working, just up and down arrow keys work to set high or low level of keyboard backlight (I use Rog-HID from Nick - black-dragon74)

Mute mic button, mute volume button (Fn+ F1), Fn+F6(Turn of screen to black), Fn+F9 (Turn to other projectors), Fn+10 (Disable trackpad), Fn+11 (Sleep), Fn+12 (Flight mode)

Trackpad is working but as I said before I use the patch from Clover (of @williambj1 to my OpenCore and tune with my understanding and not sure the patch/tune is okay, correct or not) - so that's the reason why I need a simplified guide (if there is) to patch VoodooI2C by my own, but as you mentioned about patch OpenCore is not as easy as Clover so I think I will get to adapt with OpenCore for a long time to see interesting projects developed by awesome, hard working Hackintosh developers (like you for instance :D)

Idle tempurature quite high, around 56 - 59 degree celcius, not sure whether because my CPUFriend patch isn't correct or because trackpad patch isn't correct

USB Mapping: I think everything's fine, I patched with a guide of Hackintool, not Dortania's USB Mapping guide.

Working: Everything else (Definitely sure GPU NVIDIA/HDMI not working) Not sure: Wake from sleep with lid close and open (But sleep and wake normally is okay, but I haven't patched the problem with wake from sleep when touching wireless mouse for example, causes wake instantly) GPU is disabled (with -wegnogpu and WEG/Lilu kext) not with DSDT, so not sure this completely or not)

e-senturk commented 3 years ago

I am confused about one thing are you using SSDT-I2CBus.aml for touchpad only and it is working?. If it is you don't need any patch at all. The overall build has some flaws for example battery aml might be problematic in opencore and there are some DSDT patching errors. Can you test my build and determine bugs on your side if you can my job would be much easier. If you can't boot you can disable touchpad kexts and amls which are(SSDT-OCI2C-TPXX-G531, SSDT-USTP, SSDT-OCGPI0-ETPD) and VoodooI2C kexts. Your sound is probably not gonna work with my build as well because of different id other than sound and touchpad everything has to work. Can you confirm it on your side? And use config-IntelWifi.plist for config

trankimlonghai commented 3 years ago

Hi, I did as you said ( using your OC EFI folder + config intelwifi) and here is my update:

I have to disable those SSDT: (SSDT-OCI2C-TPXX-G531, SSDT-USTP, SSDT-OCGPI0-ETPD) and just enable 1 airport intel wifi kext (I đisabled the other two) then my machine can boot to macOS successfully At a glance I tested and it appeared that all working fine even audio, usbport kext maybe not working correctly but it's okay I can patch this again later (but not really sure your usbport kext can also be worked with my G531GU or not)

Idle temp seems more okay 52 - 55 temp, maybe because the trackpad not working as I disabled those SSDT I mentioned about you guided me

Okay that's all for now if you need anything else don't hesistate to contact me, I will test it, thanks!

(And after I booted successfully to your Oc efi folder I noticed a message that you are using 0.6.4 or .5 use at your own risk bla bla... maybe your version of OC is older ? But this is not necessary, isn't it? We can manually update Oc to newer version later)

e-senturk commented 3 years ago

Yes I didnt updated build for a while thats why some kexts are old. My idle temps are near 50 degrees and it seems thats fine windows works lower temperatures because it has proper fan configuration sadly I can't generate proper SSDT for our fan its very complicated and there are not enough resources for it. I am not using any kexts or patch for usb port because it's not needed in out device thats totally as expected I'll add your patch for your build.

trankimlonghai commented 3 years ago

Yeah, it's kinda cool about temperature in Windows because I undervolted to make it idle around 42 - 46 degree and stable performance but Hackintosh (macOS) seems not easy to get a lower temperature.

UPDATE: About USBPortKext (my kext) I don't know if it works or not, I think I patched not correctly because I tried remove all ports in Hackintool then press refresh button, the layouts I patched backed to default (like not be patched) but sleep still work, I don't understand this because I remember if USBPorts are patched correcly, sleep will work without problems!

But your EFI OC folder contains at the same time SSDT UIAC and USBPorts kext, these are enabled at the same time ? USB patch guide says or we use SSDT UIAC or we use only USBPortKext ??

  1. Yes, it's working, here's what I used:
    • SSDT-I2CBus.aml + change "USTP, 8" to "XSTP, 8", pair with SSDT-I2CBus (Find 55535450 08 Replace 58535450 08)

=> As I said I just like copy/paste and tune base on what I can do and understand from Clover patch of @williambj1 to OpenCore, I don't think it will work but YES, IT WORKED! (VoodooI2C + VoodooI2CHID kext)

  1. I think sleep working! (I did as you instructed me to do about 10 mins - the blink keyboard with red LED - like in Windows) - but do note that even I use wired or wireless mouse, I just click (or maybe move the mouse) my laptop will wake, is this considered as an issue ? I remembered Dortania has patch for this but I haven't read and haven't fixed this yet.

  2. Mine (G531GU) also ALC294, I use alcid=13 (with my build EFI OC), I think I have no issue with this ALC294 (but I use your configIntelWifi plist and haven't yet touched to ALC294 ID, but yeah it's still working)

e-senturk commented 3 years ago

Ok we are getting somewhere. Only issue is touchpad because these patches you use still not OK for opencore. It might work but in the feature it might create confliction with other oses such as windows. Opencore wants 0 DSDT patches. Only patch I use in my build related with a bios bug(There is a duplicated method in our bios and makes issue in linux as well) in asus and beneficial for other oses too. If I can provide viable solution to opencore for your device I ll support it in feature versions as well. So test these: 1-) Disable Force kext to load patch and CoolStar (These patches are old and useless it should be work without them) let me know in that way is it working. 2-) Disable SSDT-I2CBus.aml and "USTP, 8" to "XSTP, 8" and enable SSDT-USTP.aml from my build and test. Please let me know the results. If thats not work I had to create a new USTP for your device.

trankimlonghai commented 3 years ago

Hi, I did as 1) and 2) from yours, so the answer is YES, IT WORKED!

I tried using my build EFI OC (still in my USB stick) and remove things like you said ( CoolStar, ForceKext, Disable SSDT-I2CBus.aml and "USTP, 8" to "XSTP, 8") and copy/using ONLY your SSDT-USTP.aml (Include VoodooI2C+ Voodoo2HID) to my build EFI OC => Snapshot and Enabled => Reboot => Working!

Besides, I think my keyboard has problem, not sure this is because I use Rog HID or not, sometimes I boot to my EFI OC build (or yours) keyboard not working, I can't press any button, sometimes restart helps make the keyboard work, sometimes not. But as my EFI OC build, I tried removing USBPortKext and use USBInjectAll and it works. Do you know what's going here ? Just don't know why...

But if patch USB Ports, which guide you find it useful and easy to follow ?

e-senturk commented 3 years ago

its roghid dont use it. I removed it for now. Its not working because developers keyboard model is not exactly to same with ours. Its nice to know everything works with 2. When I update my build I ll add G531GU config as well you can use it in feature releases if you have any other issues feel free to ask.

e-senturk commented 3 years ago

also please share your last usbkext

trankimlonghai commented 3 years ago

Okay I will repatch usbkext once more and send you the file in an hour or 2

Thanks!

Ah I forgot, one more question. If you say you dont use rog hid then you use AsusSMC lastest version of hiepvip ?

Hm... I see the changelog of the lastest version he said he drop support for HID because he did not make it work on macOS catalina and above ? But you could use the kext, how ? 😄 or if not then ưhat method you made hid to work to control some fn keys,toggle max or min level of keyboard backlight... ?

e-senturk commented 3 years ago

no roghid is not stable and asussmc is not working up to 10.14 so you cant use any of them our asus keyboard model is not ps2 model it works with hid interface because of that we can't use modding it with SSDT edit. AsusSMC was using karabiner's method but it wasn't working since then I've tried to fix it but it didn't work out. I am actualy using rogswitch with some edit. But its not my app so I don't want to share edited version. You can test macAura from serdeliuk if you want.

trankimlonghai commented 3 years ago

Ah I see... so you just use macaura to control rgb lights and brightness key set max or set low level you use alternate key by changing in keyboard setting right ?

e-senturk commented 3 years ago

basicly yes. Its more stable solution for now if I find something better or write some better app by myself I ll share.

trankimlonghai commented 3 years ago

@valinor61 hi, here's my USBPorts kext: https://drive.google.com/file/d/1Di7zL00TsplVAgzc0Dn1ozyblg97pcDl/view?usp=sharing I think to make it work properly I included and enabled for patch: EHC1 => EH01; EHC2 => EH02 ; XHCI => XHC ; XHC1 => XHC in ACPI -> Patch (OC)

e-senturk commented 3 years ago

What happening if you dont enable these patches? Because using patches like that might harm windows in opencore. These patches applies all oses thats why they should avoided. If there is a necessity you need to add them with custom ssdt

trankimlonghai commented 3 years ago

What happening if you dont enable these patches? Because using patches like that might harm windows in opencore. These patches applies all oses thats why they should avoided. If there is a necessity you need to add them with custom ssdt

Ah I've just disabled those 4 patches, definitely no need to enable them, anyway I think my patch still works as expected ;) just use it until there's someone report problems with it.