Converted global variable to static class

e-sites / php-mysql-mysqli-wrapper

MIT License

99 stars 40 forks source link

Converted global variable to static class #3

Open notian opened 6 years ago

notian commented 6 years ago

The global $link was a little generic, and I'd be worried it would be overwritten in a sprawling codebase. Converted it (and the global_link_identifier) function to a static class property/function.

The mysqli_result type hinting was causing fatal errors. Removed the type hint and added a "result validator" to return bool true/false (with a warning). To better emulate the original behaviour.

sjoerdmaessen commented 4 years ago

Good changes in the PR, I will see how this can be merged with the current version in master