e-square-io / nx-github-actions

A set of Github Actions for NX workspaces
MIT License
31 stars 6 forks source link

fix: missing deps of deps in final build #32

Closed ronnetzer closed 2 years ago

ronnetzer commented 2 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

some deps require @actions/* and they're excluded

What is the new behavior?

include all deps in final build

Does this PR introduce a breaking change?

[ ] Yes
[x] No
codecov[bot] commented 2 years ago

Codecov Report

Merging #32 (fedc6b5) into main (1f7f3d2) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   86.24%   86.24%           
=======================================
  Files          13       13           
  Lines         349      349           
  Branches       51       51           
=======================================
  Hits          301      301           
  Misses         38       38           
  Partials       10       10           
Flag Coverage Δ *Carryforward flag
nx-affected-matrix 97.77% <ø> (ø)
nx-distributed-task 91.89% <ø> (ø)
utils 83.52% <ø> (ø) Carriedforward from 1f7f3d2

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d8dd0c8...fedc6b5. Read the comment docs.

nx-cloud[bot] commented 2 years ago

☁️ Nx Cloud Report

CI ran the following commands for commit fedc6b588143fcdc4511a674069bd64661fe306b. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets - [`nx run-many --projects=nx-affected-matrix,nx-distributed-task --target=build --scan --parallel --maxParallel=3`](https://nx.app/runs/G1hZUTwVnbJ) - [`nx run-many --projects=nx-affected-matrix,nx-distributed-task --target=test --scan --parallel --maxParallel=3`](https://nx.app/runs/dGuqGtWyi6g)

Sent with 💌 from NxCloud.