e-square-io / nx-github-actions

A set of Github Actions for NX workspaces
MIT License
30 stars 6 forks source link

fix(utils): configuration is not parsed from args & args name format #36

Closed ronnetzer closed 2 years ago

ronnetzer commented 2 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

-c arg is being ignored when parsed to NxArgs

What is the new behavior?

-c will be replaced with --configuration so it will be parsed correctly

Does this PR introduce a breaking change?

[ ] Yes
[x] No
nx-cloud[bot] commented 2 years ago

☁️ Nx Cloud Report

CI ran the following commands for commit 3138b043631450358696f68cbc66dc5a28dcea19. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 3 targets - [`nx run-many --projects=nx-affected-matrix --target=build --skip-nx-cache=false --parallel=3`](https://nx.app/runs/JmtGbYU3oCu) - [`nx run-many --projects=nx-distributed-task,nx-affected-matrix --target=build --skipNxCache=false --scan --parallel=3`](https://nx.app/runs/loQmRMJm2Be) - [`nx run-many --projects=nx-distributed-task,utils,nx-affected-matrix --target=test --skipNxCache=false --scan --parallel=3`](https://nx.app/runs/Luwf8ch8Nkc)

Sent with 💌 from NxCloud.

codecov[bot] commented 2 years ago

Codecov Report

Merging #36 (3138b04) into main (3d222f7) will decrease coverage by 0.20%. The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   86.49%   86.28%   -0.21%     
==========================================
  Files          15       15              
  Lines         348      350       +2     
  Branches       50       52       +2     
==========================================
+ Hits          301      302       +1     
  Misses         38       38              
- Partials        9       10       +1     
Flag Coverage Δ
nx-affected-matrix 95.91% <ø> (ø)
nx-distributed-task 90.47% <100.00%> (+0.11%) :arrow_up:
utils 82.48% <50.00%> (-0.39%) :arrow_down:
Impacted Files Coverage Δ
packages/utils/src/lib/inputs.ts 64.86% <50.00%> (-1.81%) :arrow_down:
packages/nx-distributed-task/src/app/nx.ts 85.71% <100.00%> (+0.42%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2ced032...3138b04. Read the comment docs.