e-square-io / nx-github-actions

A set of Github Actions for NX workspaces

MIT License

30 stars 6 forks source link

fix: cant get task configuration when resolving customHasher #41

Closed ronnetzer closed 2 years ago

ronnetzer commented 2 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: CONTRIBUTING.md
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

cant resolve custom hasher due to nx internals using require directly.

Issue Number: N/A

What is the new behavior?

will now resolve the custom hasher without throwing the error

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

nx-cloud[bot] commented 2 years ago

☁️ Nx Cloud Report

CI ran the following commands for commit aaf6e875fbb3a40cf63a244fb242ef6f8f5f46f8. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 4 targets

- [`nx run-many --projects=nx-affected-matrix,nx-distributed-task --skip-nx-cache=false --target=build --parallel=3 --with-deps`](https://nx.app/runs/E5DDigtCtrD) - [`nx run-many --projects=nx-affected-matrix,nx-distributed-task --skip-nx-cache=false --target=test --parallel=3 --with-deps=false`](https://nx.app/runs/VCoP54L7LGl) - [`nx run-many --projects=nx-affected-matrix,nx-distributed-task,utils --skip-nx-cache=false --target=build --parallel=3 --scan`](https://nx.app/runs/13OqT054fgV) - [`nx run-many --projects=nx-affected-matrix,nx-distributed-task,utils --skip-nx-cache=false --target=test --parallel=3 --scan`](https://nx.app/runs/2hf5CyjXMgk)

Sent with 💌 from NxCloud.

codecov[bot] commented 2 years ago

Codecov Report

Merging #41 (aaf6e87) into main (53cd2c4) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage   88.12%   88.12%           
=======================================
  Files          15       15           
  Lines         362      362           
  Branches       50       50           
=======================================
  Hits          319      319           
  Misses         39       39           
  Partials        4        4

Flag	Coverage Δ
nx-affected-matrix	`95.91% <ø> (ø)`
nx-distributed-task	`100.00% <ø> (ø)`
utils	`81.61% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b07bf3...aaf6e87. Read the comment docs.