e-square-io / nx-github-actions

A set of Github Actions for NX workspaces
MIT License
30 stars 6 forks source link

[FEAT] Remove the usage of actions/github-script #43

Open ronnetzer opened 2 years ago

ronnetzer commented 2 years ago

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

currently the actions use actions/github-script in order to run the main methods. when using actions/github-script you can't use require directly and need to use __original_require__ that is accessible from this action. This has forced us to override a lot of NX internals in order to bypass the usage of require

Expected behavior

It would be cleaner and more maintainable to remove action/github-script entirely and use the methods with pure js. We should keep the separation that was made between using github's toolkit and the actions BL, it will make it easier to consider migrating into an docker-based action so it could be possible to use it in gitlab as well