search

e-square-io / nx-github-actions

A set of Github Actions for NX workspaces
MIT License
30 stars 6 forks source link

fix(nx-distributed-task): running NX command is not working with pnpm #44

Closed robinpellegrims closed 2 years ago

robinpellegrims commented 2 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: fixes https://github.com/e-square-io/nx-github-actions/issues/40

What is the new behavior?

-p @nrwl/cli arguments are only added for npm/yarn and no longer for pnpm

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

nx-cloud[bot] commented 2 years ago

☁️ Nx Cloud Report

CI ran the following commands for commit 13b4906f1f689a628dd0485e016cbc451363312e. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 4 targets - [`nx run-many --projects=nx-affected-matrix,nx-distributed-task --skip-nx-cache=false --target=build --parallel=3 --with-deps`](https://nx.app/runs/UNJnGcBtkRg) - [`nx run-many --projects=nx-affected-matrix,nx-distributed-task --skip-nx-cache=false --target=test --parallel=3 --with-deps=false`](https://nx.app/runs/7Znn3p2ynVh) - [`nx run-many --projects=nx-distributed-task --skip-nx-cache=false --target=build --parallel=3 --scan --with-deps`](https://nx.app/runs/fuxxCzjUd8I) - [`nx run-many --projects=nx-distributed-task --skip-nx-cache=false --target=test --parallel=3 --scan --with-deps=false`](https://nx.app/runs/rrCmacneYVe)

Sent with 💌 from NxCloud.

codecov[bot] commented 2 years ago

Codecov Report

Merging #44 (13b4906) into main (4df7758) will increase coverage by 0.15%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   88.42%   88.58%   +0.15%     
==========================================
  Files          15       15              
  Lines         363      368       +5     
  Branches       51       52       +1     
==========================================
+ Hits          321      326       +5     
  Misses         39       39              
  Partials        3        3
Flag Coverage Δ *Carryforward flag
nx-affected-matrix 95.91% <ø> (ø) Carriedforward from 4df7758
nx-distributed-task 100.00% <100.00%> (ø)
utils 82.14% <ø> (ø) Carriedforward from 4df7758

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/nx-distributed-task/src/app/nx.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c31e74e...13b4906. Read the comment docs.