ronnetzer commented 2 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: CONTRIBUTING.md
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

with-deps argument is being added to every command whether its true or false

Issue Number: N/A

What is the new behavior?

added support for checking if should use withDeps for dependency graph for nx 14 removed with-deps arg from nxCommand explicitly in nx 14

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

nx-cloud[bot] commented 2 years ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c56484d207b88dd356d6b994977a2b26ac6dad24. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 4 targets

- [`nx run-many --projects=nx-affected-matrix,nx-distributed-task --skip-nx-cache=false --target=build --parallel=3 --with-deps`](https://nx.app/runs/QhHeD1SiBgO) - [`nx run-many --projects=nx-affected-matrix,nx-distributed-task --skip-nx-cache=false --target=test --parallel=3 --with-deps=false`](https://nx.app/runs/sDh3cWrWxby) - [`nx run-many --projects=nx-distributed-task,nx-affected-matrix --skip-nx-cache=false --target=build --parallel=3 --scan --with-deps`](https://nx.app/runs/wCwUoyWowBq) - [`nx run-many --projects=nx-distributed-task,utils,nx-affected-matrix --skip-nx-cache=false --target=test --parallel=3 --scan --with-deps=false`](https://nx.app/runs/oM5cw3A4EXU)

Sent with 💌 from NxCloud.

codecov[bot] commented 2 years ago

Codecov Report

Merging #51 (c56484d) into main (0a397f7) will decrease coverage by 1.97%. The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   88.58%   86.61%   -1.98%     
==========================================
  Files          15       15              
  Lines         368      381      +13     
  Branches       52       55       +3     
==========================================
+ Hits          326      330       +4     
- Misses         39       48       +9     
  Partials        3        3

Flag	Coverage Δ
nx-affected-matrix	`95.91% <ø> (ø)`
nx-distributed-task	`95.19% <50.00%> (-4.81%)`	:arrow_down:
utils	`80.70% <0.00%> (-1.45%)`	:arrow_down:

Impacted Files	Coverage Δ
packages/utils/src/lib/inputs.ts	`58.33% <0.00%> (-4.17%)`	:arrow_down:
packages/nx-distributed-task/src/app/nx.ts	`88.09% <50.00%> (-11.91%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e0a1f7f...c56484d. Read the comment docs.

e-square-io / nx-github-actions

fix: with-deps removed in nx 14 #51