e-square-io / nx-github-actions

A set of Github Actions for NX workspaces
MIT License
30 stars 6 forks source link

fix(nx-distributed-task): undefined args are not filtered out #52

Closed ronnetzer closed 2 years ago

ronnetzer commented 2 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No
nx-cloud[bot] commented 2 years ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b5d1697eec408b7a9978f9c2b0925aea78548f5f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets - [`nx run-many --projects=nx-affected-matrix,nx-distributed-task --skip-nx-cache=false --target=build --parallel=3 --with-deps`](https://nx.app/runs/KmXTTluUHic) - [`nx run-many --projects=nx-affected-matrix,nx-distributed-task --skip-nx-cache=false --target=test --parallel=3 --with-deps=false`](https://nx.app/runs/yhxFewMx8OF) - [`nx run-many --projects=nx-distributed-task --skip-nx-cache=false --target=build --parallel=3 --scan --with-deps`](https://nx.app/runs/A3FXkJfzmKu) - [`nx run-many --projects=nx-distributed-task --skip-nx-cache=false --target=test --parallel=3 --scan --with-deps=false`](https://nx.app/runs/C6RIggxDZAM)

Sent with 💌 from NxCloud.

codecov[bot] commented 2 years ago

Codecov Report

Merging #52 (b5d1697) into main (57441b6) will increase coverage by 1.31%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   86.61%   87.92%   +1.31%     
==========================================
  Files          15       15              
  Lines         381      381              
  Branches       55       55              
==========================================
+ Hits          330      335       +5     
+ Misses         48       43       -5     
  Partials        3        3              
Flag Coverage Δ *Carryforward flag
nx-affected-matrix 95.91% <ø> (ø) Carriedforward from 57441b6
nx-distributed-task 100.00% <100.00%> (+4.80%) :arrow_up:
utils 80.70% <ø> (ø) Carriedforward from 57441b6

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/nx-distributed-task/src/app/nx.ts 100.00% <100.00%> (+11.90%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bec6b3d...b5d1697. Read the comment docs.