e-square-io / nx-github-actions

A set of Github Actions for NX workspaces
MIT License
30 stars 6 forks source link

fix(nx-affected-matrix): e2e apps are ignored #55

Closed ronnetzer closed 2 years ago

ronnetzer commented 2 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

e2e apps are being ignored from affected calculations

Issue Number: fixes #54

What is the new behavior?

e2e apps will be added to the apps array

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

nx-cloud[bot] commented 2 years ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 06a9ee5c18ad25678924aa5023826a32d2991fbf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets - [`nx run-many --projects=nx-affected-matrix --skip-nx-cache=false --target=test --parallel=3 --scan --with-deps=false`](https://nx.app/runs/JHJyJnrBbTc) - [`nx run-many --projects=nx-affected-matrix --skip-nx-cache=false --target=build --parallel=3 --scan --with-deps`](https://nx.app/runs/7g0Zie4lEPJ)

Sent with 💌 from NxCloud.

codecov[bot] commented 2 years ago

Codecov Report

Merging #55 (06a9ee5) into main (353e717) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   87.92%   87.92%           
=======================================
  Files          15       15           
  Lines         381      381           
  Branches       55       55           
=======================================
  Hits          335      335           
  Misses         43       43           
  Partials        3        3           
Flag Coverage Δ *Carryforward flag
nx-affected-matrix 95.91% <ø> (ø)
nx-distributed-task 100.00% <ø> (ø) Carriedforward from 353e717
utils 80.70% <ø> (ø) Carriedforward from 353e717

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.