e-square-io / nx-github-actions

A set of Github Actions for NX workspaces
MIT License
30 stars 6 forks source link

fix(utils): cache error is being rethrown #65

Closed ronnetzer closed 1 year ago

ronnetzer commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

currently errors from GitHub cache will be rethrown except for reserve cache error.

Issue Number: N/A

What is the new behavior?

all cache error will be caught and warned instead

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f5c0dde0cc201b6e0df5d5600df851df7e21c44c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets - [`nx run-many --projects=nx-affected-matrix,nx-distributed-task --skip-nx-cache=false --target=build --parallel=3 --with-deps`](https://cloud.nx.app/runs/ZqI8O3KUqC) - [`nx run-many --projects=nx-affected-matrix,nx-distributed-task --skip-nx-cache=false --target=test --parallel=3 --with-deps=false`](https://cloud.nx.app/runs/DJUsH53EPU) - [`nx run-many --projects=nx-distributed-task,nx-affected-matrix --skip-nx-cache=false --target=build --parallel=3 --scan --with-deps`](https://cloud.nx.app/runs/8oSvP8LmE7) - [`nx run-many --projects=utils,nx-distributed-task,nx-affected-matrix --skip-nx-cache=false --target=test --parallel=3 --scan --with-deps=false`](https://cloud.nx.app/runs/NGUthUufbt)

Sent with 💌 from NxCloud.

codecov[bot] commented 1 year ago

Codecov Report

Merging #65 (f5c0dde) into main (18a7bbe) will decrease coverage by 0.32%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   87.92%   87.59%   -0.33%     
==========================================
  Files          15       15              
  Lines         381      379       -2     
  Branches       55       54       -1     
==========================================
- Hits          335      332       -3     
- Misses         43       44       +1     
  Partials        3        3              
Flag Coverage Δ
nx-affected-matrix 95.91% <ø> (ø)
nx-distributed-task 100.00% <ø> (ø)
utils 80.08% <66.66%> (-0.62%) :arrow_down:
Impacted Files Coverage Δ
packages/utils/src/lib/inputs.ts 57.37% <0.00%> (-0.96%) :arrow_down:
packages/utils/src/lib/cache.ts 98.11% <100.00%> (-0.11%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.