search

e-square-io / nx-github-actions

A set of Github Actions for NX workspaces
MIT License
30 stars 6 forks source link

Update Nx v13 to latest v13 and add support for Nx v16 binary package #70

Closed rathpc closed 1 year ago

rathpc commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature: Add support for Nx 16+ binary package
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe: Update to latest Nx v13

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

Attention: This version of the Nx Cloud GitHub bot will cease to function on July 1st, 2023. An organization admin can update your integration here.

CI is running/has finished running commands for commit 23e96fe156829d84c37200ed025eebe0a0614c6e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 4 targets - [`nx run-many --projects=nx-affected-matrix,nx-distributed-task --skip-nx-cache=false --target=build --parallel=3 --with-deps`](https://cloud.nx.app/runs/uQTPqesPLz) - [`nx run-many --projects=nx-affected-matrix,nx-distributed-task --skip-nx-cache=false --target=test --parallel=3 --with-deps=false`](https://cloud.nx.app/runs/RN1mz8BwZo) - [`nx run-many --projects=nx-affected-matrix,nx-distributed-task --skip-nx-cache=false --target=build --parallel=3 --scan --with-deps`](https://cloud.nx.app/runs/4LI6VmlO5W) - [`nx run-many --projects=nx-affected-matrix,nx-distributed-task,utils --skip-nx-cache=false --target=test --parallel=3 --scan --with-deps=false`](https://cloud.nx.app/runs/GTsIpEtizf)

Sent with 💌 from NxCloud.

rathpc commented 1 year ago

@ronnetzer any chance you would have time to review (possibly merge and release) this change?

ronnetzer commented 1 year ago

Hi @rathpc thanks for the contribution, I'll have some time this weekend to go over it. Should I consider these changes to be breaking or did you keep the support of older versions?

rathpc commented 1 year ago

@ronnetzer this one kept support for older versions so it should be just a minor bump. I would still like to find time to update the whole project to nx16 which would indeed be a breaking change but that would be a separate much larger PR.

rathpc commented 1 year ago

@ronnetzer just checking in to see if you had a chance to take a look at this? It is currently blocking several downstream dependencies for me so I was hoping to get this merged soon. Thanks in advance!

codecov[bot] commented 1 year ago

Codecov Report

Merging #70 (23e96fe) into main (107c7d5) will decrease coverage by 0.14%. The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   87.59%   87.46%   -0.14%     
==========================================
  Files          15       15              
  Lines         379      383       +4     
  Branches       54       56       +2     
==========================================
+ Hits          332      335       +3     
- Misses         44       45       +1     
  Partials        3        3
Flag Coverage Δ
nx-affected-matrix 95.91% <ø> (ø)
nx-distributed-task 100.00% <100.00%> (ø)
utils 79.82% <71.42%> (-0.27%) :arrow_down:
Impacted Files Coverage Δ
packages/nx-distributed-task/src/app/cache.ts 100.00% <ø> (ø)
packages/nx-distributed-task/src/app/upload.ts 100.00% <ø> (ø)
packages/utils/src/lib/inputs.ts 57.14% <60.00%> (-0.24%) :arrow_down:
packages/nx-distributed-task/src/app/nx.ts 100.00% <100.00%> (ø)
packages/nx-distributed-task/src/main.ts 100.00% <100.00%> (ø)
packages/utils/src/lib/fs.ts 33.33% <100.00%> (ø)
rathpc commented 1 year ago

Thank you!!!

rathpc commented 1 year ago

Is there a workflow that has to be run to get this change updated here: https://github.com/e-square-io/nx-distributed-task?

rathpc commented 1 year ago

I think there was some issue during that release... https://github.com/e-square-io/nx-github-actions/actions/runs/5097529932/jobs/9164128041#step:6:308

ronnetzer commented 1 year ago

Thanks, noticed that too, I'll handle it today and deploy manually

rathpc commented 1 year ago

Thanks, noticed that too, I'll handle it today and deploy manually

Much appreciated!!

rathpc commented 1 year ago

Thanks, noticed that too, I'll handle it today and deploy manually

@ronnetzer were you able to get this deployed?

ronnetzer commented 1 year ago

@rathpc Seems to be fixed now 🎉 Have a great weekend and lmk if there's any other issue