e-square-io / nx-github-actions

A set of Github Actions for NX workspaces
MIT License
30 stars 6 forks source link

fix: remove -p from runner command if nx greater than 16 #76

Closed eliraneliassy closed 1 year ago

eliraneliassy commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

Attention: This version of the Nx Cloud GitHub bot will cease to function on July 1st, 2023. An organization admin can update your integration here.

CI is running/has finished running commands for commit ed03485864c1bf557d223760c8f2ebf6fb9241ed. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets - [`nx run-many --projects=nx-affected-matrix,nx-distributed-task --skip-nx-cache=false --target=build --parallel=3 --with-deps`](https://cloud.nx.app/runs/2O1NeYh5sx) - [`nx run-many --projects=nx-affected-matrix,nx-distributed-task --skip-nx-cache=false --target=test --parallel=3 --with-deps=false`](https://cloud.nx.app/runs/E3e99yneoA) - [`nx run-many --projects=nx-distributed-task --skip-nx-cache=false --target=build --parallel=3 --scan --with-deps`](https://cloud.nx.app/runs/5yggUSpmaM) - [`nx run-many --projects=nx-distributed-task --skip-nx-cache=false --target=test --parallel=3 --scan --with-deps=false`](https://cloud.nx.app/runs/YOXwaXtBee)

Sent with 💌 from NxCloud.

codecov[bot] commented 1 year ago

Codecov Report

Merging #76 (ed03485) into main (7bb8e09) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   87.46%   87.46%           
=======================================
  Files          15       15           
  Lines         383      383           
  Branches       56       56           
=======================================
  Hits          335      335           
  Misses         45       45           
  Partials        3        3           
Flag Coverage Δ *Carryforward flag
nx-affected-matrix 95.91% <ø> (ø) Carriedforward from 7bb8e09
nx-distributed-task 100.00% <100.00%> (ø)
utils 79.82% <ø> (ø) Carriedforward from 7bb8e09

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/nx-distributed-task/src/app/nx.ts 100.00% <100.00%> (ø)