Javascript import maps - Githubissues

e-valuation / EvaP

a university course evaluation system written in Python using Django

Other

95 stars 144 forks source link

Javascript import maps #2108

Closed niklasmohrin closed 4 months ago

niklasmohrin commented 8 months ago

Closes #2031

I haven't touched the typescript files yet, because I haven't decided between

trying to change the imports in the typescript files from ./csrf-utils.js to csrf-utils and teaching typescript how to resolve these modules, and
just using ./csrf-utils.js in the import map too.

I think I am slightly preferring the latter. What do you think?

richardebeling commented 8 months ago

Both fine with me. Using csrf-utils.js (possibly with leaing ./) also in inline scripts might look a bit more natural, so I'd even slightly prefer that

niklasmohrin commented 4 months ago

Closing this for now, as it does not seem too important and I would rather be around if this breaks something :D