Don't sort course_evaluations in results_evaluation_detail.html again

e-valuation / EvaP

a university course evaluation system written in Python using Django

Other

95 stars 146 forks source link

Don't sort course_evaluations in results_evaluation_detail.html again #2154

Closed richardebeling closed 3 months ago

richardebeling commented 3 months ago

It is already sorted in the view: https://github.com/e-valuation/EvaP/blob/b57ee63d84c88d13664630f758312b10c141caa3/evap/results/views.py#L183

niklasmohrin commented 3 months ago

Removing the .sort line does not fail any tests, should we add one?

richardebeling commented 3 months ago

Removing the .sort line does not fail any tests, should we add one?

Done. It's a bit annoying, the test runs for ~400ms. 70ms for results computation/caching, 280ms for rendering the page. I guess its a performance problem with the view, though, the test itself is fine I think.