e-valuation / EvaP

a university course evaluation system written in Python using Django
Other
95 stars 146 forks source link

Bump django-fsm from 2.8.1 to 3.0.0 #2160

Closed dependabot[bot] closed 2 months ago

dependabot[bot] commented 2 months ago

Bumps django-fsm from 2.8.1 to 3.0.0.

Release notes

Sourced from django-fsm's releases.

3.0.0

Integration of django-fsm into viewflow

Major Changes

  • The django-fsm package has now been fully integrated into viewflow as the viewflow.fsm package starting from version 3.0.

Deprecation Notice

  • Attention: The standalone version of django-fsm will no longer be maintained nor receive any further updates. This transition marks a significant milestone in our efforts to streamline development workflows and enhance functionality.

Action Required

  • Users requiring the new functionalities introduced in django-fsm version 3.0 or later are strongly encouraged to migrate to viewflow.fsm.
  • To facilitate a smooth transition, detailed instructions on the migration process, as well as information on accessing new features, have been provided.

Resources

Commits
  • e56c788 Merge branch 'master' of github.com:viewflow/django-fsm
  • 7eed13c Bump version
  • 7285554 Convert label to str in graph_transitions.py
  • 77a4d77 Add tests for django 4.2 and django 5.0. Close #297
  • c7e63d0 Fix error message in GET_STATE
  • cedaeb2 Implement Transition.hash and eq for 'in' operator
  • 22bc86b Merge branch 'master' of github.com:viewflow/django-fsm
  • f9ebbb4 Merge Add Mixin that allows refresh_from_db. Clse #246
  • d9effde Preserve chosen "using" DB in ConcurrentTransitionMixin
  • 716e659 docs: fix simple typo, exluding -> excluding
  • Additional commits viewable in compare view


Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Kakadus commented 2 months ago

Should we migrate to viewflow.fsm (https://github.com/viewflow/viewflow)?

richardebeling commented 2 months ago

We will probably have to migrate to something else, yes. When I last looked into this, I didn't like viewflow. I want a small, focussed library that provides me with finite state machine logic for a django model field. Viewflow is, according to their own description,

a reusable component library for creating comprehensive business applications with ease.

If you need parallel task execution, views and background task code reuse over different flows - check my new project django-viewflow: https://github.com/viewflow/viewflow

It just feels like large bloat to me. Additionally, I'm sceptic of their pay-to-win model.

There have been other efforts to continue django-fsm, I'm hoping it just will be continued as a Jazzband project. In practice, there is nothing wrong with it, we don't require any new features. A request to transfer django-fsm to Code Shelter was denied, giving the reason that it is "complete" (even though there are always the common maintenance tasks, e.g. ensuring compatibility with new django versions)