search

e-valuation / EvaP

a university course evaluation system written in Python using Django
Other
95 stars 146 forks source link

ci: track github actions with dependabot #2168

Closed Kakadus closed 2 months ago

Kakadus commented 2 months ago

Just saw some warnings in the latest ci runs, github is deprecating another node version. I never actually saw any practical incompatibilities of actions, so I told dependabot to group all ci PRs for less noise.

richardebeling commented 2 months ago

I'm a bit confused, I don't see a deprecation warning (I checked out the output of the "Compile SCSS / Setup nodejs" step). Our workflow definition file in .github/setup_nodejs/action.yml doesn't seem to specify a node version. Where exactly can I find the warning and what version specification are we talking about?

In general, I'm fine with just always running on the latest stable node version. After #2077, we're basically only using node for scss and typescript, both are big enough for that to work I guess.

Kakadus commented 2 months ago

I'm a bit confused, I don't see a deprecation warning (I checked out the output of the "Compile SCSS / Setup nodejs" step). Our workflow definition file in .github/setup_nodejs/action.yml doesn't seem to specify a node version. Where exactly can I find the warning and what version specification are we talking about?

The warnings I talked about are here if you scoll down. It is related to the node version used to execute the ci step itself. We currently use actions/checkout@v3, actions/setup-python@v4, actions/setup-node@v3 and actions/upload-artifact@3 which are all "deprecated" by github

In general, I'm fine with just always running on the latest stable node version. After #2077, we're basically only using node for scss and typescript, both are big enough for that to work I guess.

The warnings are not related to the node version we use (e.g. we could still use an old node version with the new action versions)