e-valuation / EvaP

a university course evaluation system written in Python using Django
Other
95 stars 146 forks source link

Assert that users have no passwords in anonymize command #2179

Closed richardebeling closed 1 month ago

richardebeling commented 1 month ago

Okay with me, but can you elaborate on the motivation for this change? Is it just to avoid leaking a password hash accidentally, or to avoid having a user identifiable by them having a password?

Anonymized data (possibly intended for publishing) should not contain any real password hashes. If we expected users to have passwords stored in our database, we would have to replace them. Since we don't expect users to have any password set, it felt more natural to me to just assert that this expectation holds (and we thus don't leak any critical data).