search

e-valuation / EvaP

a university course evaluation system written in Python using Django
Other
97 stars 144 forks source link

'can't give feedback' button does not clear textanswers #2302

Open Kakadus opened 1 day ago

Kakadus commented 1 day ago

To skip evaluating a contributor and select "no answer" for all its questions, the "I can't give feedback about this contributor" button can be used. If the user changes a radio input value, this button gets activated again.

After clicking this button, textanswers for that contributor are still submitted, which might be unexpected. When the contributor only has textanswers, the button is useless and cannot be activated again after being clicked once.

Instead, all textanswers for that contributor should be cleared as well - also textanswers attached to rating questions. Also see https://github.com/e-valuation/EvaP/issues/2302#issuecomment-2408051603. When the user edits a textanswer, this button should be activated again.

janno42 commented 1 day ago

After clicking the button, a confirmation modal should be displayed to confirm the deletion of the text answers to avoid losing valuable data if text answers have already been entered for that contributor.