search

e0404 / matRad

An open source multi-modality radiation treatment planning sytem developed by e0404 @ DKFZ
http://www.matRad.org
Other
227 stars 176 forks source link

BED Projection reimplementation based on PR #534 #744

Closed amitantony closed 4 months ago

amitantony commented 4 months ago

reimplementation of Jenny's PR #534 into the new matRad file structure

amitantony commented 4 months ago

@wahln if this test for the BED projection is sufficient and makes sense ill write one for all the other projections too with the same template.

JenHardt commented 4 months ago

i noticed that compared to how the original pull request was done, we are using single fraction effect, originaly we used the total fraction effect, so basically always multiply the effect by n, i think either way is fine though. Original the BED projection also work wiht a const RBE model for protons or photons this is no longer the case is that wanted?

wahln commented 4 months ago

Original the BED projection also work wiht a const RBE model for protons or photons this is no longer the case is that wanted?

I think that there's some bigger considerations by @remocristoforetti about revising the biological models. Then we need to probably adapt. But it's true that one could add support for constRBE again here. In the projection, one could just check for a constant RBE value in the dij or have some switch in the projection.

JenHardt commented 4 months ago

Original the BED projection also work wiht a const RBE model for protons or photons this is no longer the case is that wanted?

I think that there's some bigger considerations by @remocristoforetti about revising the biological models. Then we need to probably adapt. But it's true that one could add support for constRBE again here. In the projection, one could just check for a constant RBE value in the dij or have some switch in the projection.

i rember that i had a check in the effect projection