Refactor dicom importer

Raedlr commented 2 months ago

object oriented structure, import handled by matRad_DicomImporter
Adapted GUI to work with new Importer
scan is part of the importer and output adapted for better compatibility

wahln commented 2 months ago

Thanks for the Pull Request! @amitantony could you do the review? Also, we should think about a way to run tests on the DICOM import / export. First step could be to take a very small dummy ct / cst / dose, export it with the dicom exporter, and then try to reimport those by script again.

Raedlr commented 2 months ago

matRad_importDicomSteeringParticles* in the last one

amitantony commented 1 month ago

final testing required for importing particle therapy plan, then we are ready to go

wahln commented 1 month ago

I did a few changes:

added helper function to use temporary directory in tests
extended the tests to do an export and an actual reimport
temorary directory used for dicom export and reimport tests
removed GUI elements from folder scanning (I don't want to many boxes opened when we are using the exporter from script!)

In matRad_interpDicomCtCube, there still seems to be an issue in case of SliceThickness being a String in this line: https://github.com/e0404/matRad/blob/2a3c89557a7393e90e96c4a3dcd9ea4cb14d5674/matRad/dicom/matRad_interpDicomCtCube.m#L90

If this only happens with the data exported from us, then it might either be an exporter error or an import error. The standard suggests a "Decimal String" for the attribute, so its unclear.

wahln commented 1 month ago

Pushed some fixes to pass octave tests

e0404 / matRad

Refactor dicom importer #758