e0543978 / pe

0 stars 0 forks source link

Unable to undo a marked script #4

Open e0543978 opened 2 years ago

e0543978 commented 2 years ago

I think it would definitely benefit the user if they were able to undo a marked script.

Currently, after a lab is marked, it can't be unmarked. Scenarios, where a teacher updated the wrong student's score, makes it hard for them to undo their mistake.

image.png

nus-pe-bot commented 2 years ago

Team's Response

It is a valid issue but not something that our team should be penalized for as it was not related to features delivered in v1.4 and we are unable to implement new features. Furthermore, to address the issue of wrong input, the TA (user) can still edit the score using the edit or editlab command and it is not like there is NO WAY to perform UPDATE operation.

While we acknowledge that this can be considered as a feature flaw if our team did not provide any other commands to rectify the mistake. For example, if the TA marked a wrong student, eventually the TA will be able to update it to the correct score (which is provided as the edit command). UNDO can be seen as another feature that requires significant changes to our code (keeping track of states) which is mentioned in our DG as a proposed implementation but regarded as not in scope at this moment. Thank you!

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Yes, I agree to some extent that it might not be in scope. However, it should still be regarded as a feature flaw as the function can indeed be highly beneficial to the application. image.png