search

e0699194 / pe

0 stars 0 forks source link

Unable to change lesson type #5

Open e0699194 opened 3 years ago

e0699194 commented 3 years ago

There is no option to edit lesson type.

Looking at your DG, this should be easy to implement since lessonType is an attribute on the Lesson class.

image.png

nus-pe-bot commented 3 years ago

Team's Response

This was intentional. It was done to allow for future expansion of the app, where we differentiate the fields for each lesson type. Hence, we do not want to allow users to edit the lesson type.

At the same time, the lesson type is something that is unlikely to be changed in the middle of the semester, unlike the other fields. Having it there would make the instructions unnecessarily longer. The pros and cons were weighed out by the team before we made this decision.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: If the user to key in the lesson type incorrectly, he/she would have to go through the entire process of deleting and creating a new item.

:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: Although it does not crash the application, it is a major inconvenience to the user and it shows that the team did no consider possible user errors thoroughly