search

e107inc / bootstrap4

Bootstrap4 Theme folder working repo
1 stars 0 forks source link

Cardlist style now appears to depend on {SETSTYLE} #10

Closed CaMer0n closed 5 years ago

CaMer0n commented 5 years ago

Padding has returned where it should no longer be.

image

Jimmi08 commented 5 years ago

No, it depends on this $options['list'], but I forgot that there can be the opposite case 

            if($style === 'listgroup' && empty($options['list']))
            {
                $style = 'cardmenu';
            }

            if($style === 'cardmenu' && $options['list'] == 1 )
            {
                $style = 'listgroup';
            }

menuarea 1 is by default cardmenu, menuarea 2 is by default listgroup it looks like good idea to test menus in both areas.
theme should manage any case. Not sure about it now.

When option['list'] is 1? I can't find where you set this for login_menu.

CaMer0n commented 5 years ago

@Jimmi08 The detection for list should be working properly now.

Jimmi08 commented 5 years ago

It works, tested on topic view.