e107inc / e107

e107 Bootstrap CMS (Content Management System) v2 with PHP, MySQL, HTML5, jQuery and Twitter Bootstrap. Issue Discussion Room: https://gitter.im/e107inc/e107
https://e107.org
GNU General Public License v3.0
321 stars 214 forks source link

Loading external HTML or image as banner #1491

Open rica-carv opened 8 years ago

rica-carv commented 8 years ago

I'm sloooowwwllllyyy manually updating my old v1.4 (upgraded meanwhile to 2.0, with some problems & minor bugs) to the new v2.1, and stumble upon an issue with v2 banner core plugin. In v1.4, i could have an html file to render as banner, but now it doesn't work. Has this function been deprecated???

nesjett commented 8 years ago

I dont catch you, how were you doing this on v1.4? as I can see you create a campaing and asign an image to it.

There is no option for adding urls, html´s nor code, maybe are you referencing to adding html to a custom menu?

Grts,

rica-carv commented 8 years ago

@nesjett I could do that in V1.4, by assigning on the banner image field (wich was editable text on v1.4) a link to a html file, instead of a image file. Now on V2.1 you can only add images, since that field in no more editable as text.... We can't even link to an external image (as it was possible with v1.4), since we can only use images already present on the media manager...

nesjett commented 8 years ago

In my v1.4 versión i dont have such a text área, just an imagen picker (radio buttons) so, or your e107 or mine are bugged heheh

LaocheXe commented 8 years ago

@nesjett there are some ways to do that, for example change it in the database. I never missed with the banner plugin a whole lot, but I remember a few things.

@rica-carv can you send me the banner plugin files you got? forbiddenchaos@gmail.com

rica-carv commented 8 years ago

@LaocheXe The one's i'm using right now are the same that are here on github, on the banner plugin... Or you want the v1.4 ones?

nesjett commented 8 years ago

@LaocheXe yes, I can figure out how to do that, but I dont remember it by default on e107

Moc commented 8 years ago

@rica-carv What is the purpose of having an HTML page as an image? To be able to update it externally/ In that case, I agree that an external image link is something to consider, this would also take care of the need for an HTML page then (which I don't think is ever going to be supported, as it never officially was).

rica-carv commented 8 years ago

@nesjett @LaocheXe The way i was doing it on v1.4, was to have the html file on the images folder, under the banner plugin, and point the image field of a specific banner to the html file. Just that, and it worked like a charm.... @Moc Since V2.x has somehow "lost" this "abillity", i've decided to convert all my original html banners to images, so.....

Moc commented 8 years ago

@rica-carv I am trying to understand the use of the HTML file. What was the purpose of it? :) Maybe there's a different way in v2 to achieve what you want.

Also, we can make some improvement in the banner plugin. For example, I think that the banner plugin should support external images. That's why I re-opened this issue.

rica-carv commented 8 years ago

@Moc Sorry for closing this. I was primary using the HTML to make a banner from a smaller image, and also using plain text on it, for instance (check the source) Regarding external images, there's bad and good issues.... Right now, a bad issue i can think of is if the external file isn't available anymore??? On the good side, there's no space occupied on the media manager for external linked banners....

MikeyGMT commented 7 years ago

Many affiliate programmes give you the html code to use in you banner. This function was supported in previous versions of Banner.

rica-carv commented 7 years ago

@MikeyGMT Indeed, but now the only way is to have a image for the banner, no HTML...

CaMer0n commented 7 years ago

I think we'll need another field for html.

rica-carv commented 7 years ago

Or try to get back to the old v1.x way. If you have a field for HTML and another for the image, it might get some conflicts, for instance, if you have already loaded a image inside the HTML....

CaMer0n commented 7 years ago

The old v1.x way has no way to enter raw HTML code from what I can see.

rica-carv commented 7 years ago

@CaMer0n No, it doesn't, but instead of the image path, you could have a path to a HTML file that had its banner rendered, ie: <img src='https://raw.github.com/jlongster/mozilla.org/master/contribute/buttons/468x60arrow_b_pt.png' alt='Firefox Download Button' border='0' />