[Bug] User rating - Githubissues

e107inc / e107

e107 Bootstrap CMS (Content Management System) v2 with PHP, MySQL, HTML5, jQuery and Twitter Bootstrap. Issue Discussion Room: https://gitter.im/e107inc/e107

https://e107.org

GNU General Public License v3.0

321 stars 213 forks source link

[Bug] User rating #1933

Open nesjett opened 7 years ago

nesjett commented 7 years ago

In the latest stable version, if you try to rate a user with half a star, it shows an error on the javascript alert()

The error seems to happen because a print_a() function its around there (because it shows <pre></pre> markups inside the alert popup)

Grts,

Moc commented 6 years ago

It may very well be that this issue is already resolved in the latest update. Please try updating from Github before we look into this issue more closely.

There is an easy way to sync with Github:

Enable developer mode in Admin Area > Preferences > Advanced features
Go to Admin Area > Tools > Database > Sync with Github
Press the Overwrite files button and wait until the process has finished.

Alternatively you can download the ZIP file with all the latest files included by hitting the green 'Clone or download' button at the top of this page: https://github.com/e107inc/e107

Moc commented 6 years ago

@nesjett Is this still an issue with the latest version?

Moc commented 5 years ago

Confirmed. It's due to the fact that rates are only stored in full stars (1 to 5 by default) and not halfs. You are however able to select half stars.

@CaMer0n @nesjett @Jimmi08 @rica-carv @BigBoiJefe Does anyone know if it was ever possible to rate using half stars? Looking at the code, I think not.

I think it's best to limit it to full stars (numbers) rather than to also use halfs.

Also; Raty.js should be updated as it might actually be a bug in that library (looking at their changelog).