Open MikeyGMT opened 7 years ago
It might be, since now the email icon & button is on the social plugin...
Ah OK - have yet to play with social plugin. I'll leave the lans alone for emailicon.
But for some reason, i can't figure out why the send email button has anything to do with the social plugin, if there's already a core one.... Why no use it inside the social plugin?
Just my thoughts....
I'm looking to comment all unused LANs for #6 to reduce the number of LANs for translators. Hence, if they're not used, then let's disable them.
But for some reason, i can't figure out why the send email button has anything to do with the social plugin, if there's already a core one.... Why no use it inside the social plugin?
Probably because it is a leftover from v1
@Moc ?
Probably because it is a leftover from v1
What's leftover from V1? The Email button shortcode, or the inclusion of it inside the social plugin (which i can't yet understand why it's there).
For instance, what if i want to use that button isolated fom all the social buttons?
As far as I understand it: {EMAILICON} was present in v1, now in v2 the social plugin combines a lot of these sharing options (social media but also email). There are thus two options to share via email: the emailicon and the social plugin.
I may be incorrect though, I don't use either.
@Moc I also understand that, but in my v1.x site i had the regular legacy email button, wich allowed me also to put it wherever i want it. If now the legacy button is scheduled to go, in favor of the social plugin button row, there's a big issue in that ideia.... How can the social plugin render only the email button?
@CaMer0n What do you think?
@Moc No, it's not deprecated.. as you can see here in the news shortcodes:
/**
* {EMAILICON: class=x}
*/
function sc_emailicon($parm=array())
{
$pref = e107::getPref();
if (!check_class(varset($pref['email_item_class'],e_UC_MEMBER)))
{
return '';
}
require_once(e_HANDLER.'emailprint_class.php');
return emailprint::render_emailprint('news', $this->news_item['news_id'], 1, $parm);
}
It would have @deprecated
in the docs above the function/shortcode if it were.
If it's not deprecated, why social icons plugin uses it's own emailicon, instead of the core one? Why reinvent the wheel?
Looking at email.php for lans rework, but looks like {EMAILICON} is no longer used on templates. So is email.php deprecated?