search

e107inc / e107

e107 Bootstrap CMS (Content Management System) v2 with PHP, MySQL, HTML5, jQuery and Twitter Bootstrap. Issue Discussion Room: https://gitter.im/e107inc/e107
https://e107.org
GNU General Public License v3.0
321 stars 214 forks source link

Forum image upload/resizing not discarding original image #3020

Open martyshep opened 6 years ago

martyshep commented 6 years ago

In Forum plugin, when users upload an image, it gets resized when displayed in the forum, but the uploaded file in /e107media/~/plugins/forum/attachments/user is still the same size.

The filename in /e107media/~/plugins/forum/attachments/user~ is prefixed with 'epoch-timeuserid' when uploaded, but that file is just a rename of the uploaded file, no resizing has occurred there.

I thought setting the Forum plugin preference 'Create link to full size image = OFF' would mean the uploaded image is resized after upload and the original size file discarded?

The forum display works fine and displays a smaller resized image.

The issue for me is that it uses up more of my hosting space. Is this working as intended or a bug? Just wanted to understand the operation, as the tooltip suggests "Enabling this will resize larger images and also create a link to the original full size image. If disabled, original image will be discarded" Kinda suggests that the newly created file 'epoch-time_userid_filename' would be smaller size that the original, but it is the same size. /Martin

CaMer0n commented 6 years ago

@martyshep When the thumb.php was introduced, the idea was to keep high resolution versions of everything so multiple sizes could be generated from the 'original'. Also, with retina displays we actually need double the resolution. You're right though, the pref is misleading due to its age.

martyshep commented 6 years ago

Thanks @cameron good to know