search

e107inc / e107

e107 Bootstrap CMS (Content Management System) v2 with PHP, MySQL, HTML5, jQuery and Twitter Bootstrap. Issue Discussion Room: https://gitter.im/e107inc/e107
https://e107.org
GNU General Public License v3.0
321 stars 213 forks source link

just note - little problem with caching script (to one file) #3458

Open Jimmi08 opened 5 years ago

Jimmi08 commented 5 years ago

I (by mistake) defined script and css this way: e107::css("theme", "vendor/revolution-plugin/revolution-addons/particles/css/revolution.addon.particles.css?ver=1.0.3");

Everything worked, so I didn't notice this. But then I set caching on and after hours of digging I found that script (js + css) written this way is ignored. (or better inserted empty).

By the way, I found wrong defined js very quickly, but it didn't help. It takes me hours to find that I need to check css too (:

rica-carv commented 5 years ago

By mistake? CSS & JS aren't to be included this way? If not, how is supposed to be the correct way to include them?

Jimmi08 commented 5 years ago

@rica-carv this was problem: ?ver=1.0.3 with this, it wasn't part of one css or js file. I really don't know.

CaMer0n commented 5 years ago

@Jimmi08 This is because you provided a URL (with query), instead of a simple file path. I suggest you download v1.0.3 of the script and save it locally to your theme folder.

Jimmi08 commented 5 years ago

It is one file already saved locally, I just deleted rest after ? .

Problem is that it works without caching and it doesn't with it.

So if this is not allowed, it shouldn't work without caching too.