e107inc / e107

e107 Bootstrap CMS (Content Management System) v2 with PHP, MySQL, HTML5, jQuery and Twitter Bootstrap. Issue Discussion Room: https://gitter.im/e107inc/e107
https://e107.org
GNU General Public License v3.0
322 stars 214 forks source link

chatbox notify title - html code is there #3726

Closed Jimmi08 closed 4 years ago

Jimmi08 commented 5 years ago

Subject of chatbox notify email

image

Moc commented 5 years ago

Hmm, I cannot reproduce this. I do not see any reason in the code that would cause this. I assume you are using the latest files?

Which theme are you using?

Jimmi08 commented 5 years ago

@Moc RideBlue2

Moc commented 5 years ago

I reproduced the issue on RideBlue2, looking into it.

Moc commented 5 years ago

Ok, took a while but I found the issue. Not sure about the fix though:

@CaMer0n in e107_handlers/mail.php on line 856, this is done:

$this->Subject = $tp->parseTemplate($tmpl['subject'], true, varset($eml['shortcodes'],null));

It merges with this in the RideBlue2 theme.php, used for the $COMMENTSTYLE in theme.php.

$sc_style["SUBJECT"]["pre"] = '<td class="forumheader">';
$sc_style["SUBJECT"]["post"] = '</td></tr>';

I see a note here in e107_handlers/mail.php on line 834 when loading the email template:

if($tmpl = e107::getCoreTemplate('email', $eml['template'], 'front', true))  //FIXME - Core template is failing with template 'notify'. Works with theme template. Issue with core template registry?

Can you take a look please?

CaMer0n commented 4 years ago

@Moc Thanks for the tips.

I believe the commit should fix it, but if not, please re-open. Thank you both!