e107inc / e107

e107 Bootstrap CMS (Content Management System) v2 with PHP, MySQL, HTML5, jQuery and Twitter Bootstrap. Issue Discussion Room: https://gitter.im/e107inc/e107
https://e107.org
GNU General Public License v3.0
320 stars 214 forks source link

Not all folders configurable from e107_config.php by default #3774

Open nlstart opened 5 years ago

nlstart commented 5 years ago

In install.php as from line 1368 these settings are being written to the e107_config.php file:

\$ADMIN_DIRECTORY     = '{$this->e107->e107_dirs['ADMIN_DIRECTORY']}';
\$FILES_DIRECTORY     = '{$this->e107->e107_dirs['FILES_DIRECTORY']}';
\$IMAGES_DIRECTORY    = '{$this->e107->e107_dirs['IMAGES_DIRECTORY']}';
\$THEMES_DIRECTORY    = '{$this->e107->e107_dirs['THEMES_DIRECTORY']}';
\$PLUGINS_DIRECTORY   = '{$this->e107->e107_dirs['PLUGINS_DIRECTORY']}';
\$HANDLERS_DIRECTORY  = '{$this->e107->e107_dirs['HANDLERS_DIRECTORY']}';
\$LANGUAGES_DIRECTORY = '{$this->e107->e107_dirs['LANGUAGES_DIRECTORY']}';
\$HELP_DIRECTORY      = '{$this->e107->e107_dirs['HELP_DIRECTORY']}';
\$MEDIA_DIRECTORY     = '{$this->e107->e107_dirs['MEDIA_DIRECTORY']}';
\$SYSTEM_DIRECTORY    = '{$this->e107->e107_dirs['SYSTEM_DIRECTORY']}';

However, I think the e107_core and the e107_web folders are missing to be made configurable.

nlstart commented 5 years ago

it is stated on https://e107.org/developer-manual/ in 'Files and Folders' that these folders cannot be modified; however, that is also stated for the e107_admin and the e107_handler folders, yet they are being offered to be made configurable.

Jimmi08 commented 5 years ago

You can add to your config file this manually

$CORE_DIRECTORY = 'core/';
$WEB_DIRECTORY = 'web/';

And you need to change .htaccess too if you change Images and File folders.

You shouldn't change handler and admin folders before installation, because names are hardcoded image

By the way, where you found in documention that "that these folders cannot be modified" ? I can see there only there changes inside those folders shouldn't be made.

PS. Nice to see your nick here :)

nlstart commented 5 years ago

image

CaMer0n commented 5 years ago

@nlstart That means the content can be modified. It has nothing to do with the paths in e107_config.php. Defaults are set when paths are not found in this file.

Jimmi08 commented 5 years ago

@nlstart I use non-prefix version on one site more than 2 years without issues. CaMeRon answer is correct.

nlstart commented 5 years ago

@nlstart That means the content can be modified. It has nothing to do with the paths in e107_config.php. Defaults are set when paths are not found in this file.

Makes sense now, wasn't so clear after reading the developer manual. Plus that not all configurable paths are placed in the initial e107_config.php by install.php.

CaMer0n commented 5 years ago

Ideally, I'd like to see them all commented out. (see last commit)