Config file wrong creation

[tgtje]

Due to examining some causes discovered using file inspector (showing e107 files folder) took a look at config file also.

The latest files from svn > installed > config php creates FILES as files directory CORE directory is NOT created in config ( at fileserver it is opposite > Core folder exist; Files folder not).

more http://e107.org/e107_plugins/forum/forum_viewtopic.php?247417.0

[myovchev]

I don't understand the issue. e107_files is deprecated. FILES_DIRECTORY constant is replaced by MEDIA_FILES_DIRECTORY. FILES_DIRECTORY should stay because of BC (old plugins). This constant is subject of removal. I don't think the issue is proper described. From the forum topic I understand it is somehow youtube bbcode related.

[tgtje]

I will try to explain more broadly.

Using the svn (downloaded as zip) version 2. (date download and install 7 august 2013)

Made a fresh install : the created config file with that installment created the e107 (txt line)

copy : config created with/from master_zip :

$ADMIN_DIRECTORY = 'e107_admin/'; $FILES_DIRECTORY = 'e107_files/'; <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< $IMAGES_DIRECTORY = 'e107_images/'; $THEMES_DIRECTORY = 'e107_themes/'; $PLUGINS_DIRECTORY = 'e107_plugins/'; $HANDLERS_DIRECTORY = 'e107_handlers/'; $LANGUAGES_DIRECTORY = 'e107_languages/'; $HELP_DIRECTORY = 'e107_docs/help/'; $MEDIA_DIRECTORY = 'e107_media/'; $SYSTEM_DIRECTORY = 'e107_system/';

Regarding the relationship to bbcode problem, it was made/posted as a 'consideration point" ( ala.. that is what was (looked) 'out of the order' from normal installments), and might have an influence.. that's all. At that point i noticed that in config : (was aware of new directory/media) so it seemed an error , hence issue made. ( To be honest, i discovered it while searching for a possible clue, and looking now backwards to earlier created v2 config files : they do all carry the line)

As i now understand from this mail the line in question should STAY IN the config file (for bc reasons) !?. I was totally unaware nor have read that somewhere helas.

If that is the case, then it may certainly be removed, however since i didn't know that (, it could best be communicated for future usage ? (explaining that line is present use for bc only) ?

Hoping it is more clear now, and if that is the case (bc) issue may be removed.

Regards Leo aka Tgtje

Op 27-8-2013 12:13, Miroslav Yovchev schreef:

I don't understand the issue. e107_files is deprecated. FILES_DIRECTORY constant is replaced by MEDIA_FILES_DIRECTORY. FILES_DIRECTORY should stay because of BC (old plugins). This constant is subject of removal. I don't think the issue is proper described. From the forum topic I understand it is somehow youtube bbcode related.

— Reply to this email directly or view it on GitHub https://github.com/e107inc/e107/issues/428#issuecomment-23325564.

[myovchev]

The main point is - old plugins use $FILES_DIRECTORY, if you upgrade your e107 v1 you'll have e107_files folder with some files used by these plugins. In other hand, I'm not sure $FILES_DIRECTORY should stay on new installs OR it should at least contain the value (default path) of MEDIA_FILES. So here you have a point. I'll mark this as a pending task, it'll be discussed at some point.

[tgtje]

Agreed. Overthinking the last post i think a discussion will be needed on that subject.

[tgtje]

Just adding to basically same issue : : when upgrading (june 2014) the config file remains original. Is it necessary (for any new updates (v1 = v2 > becomes v 2.x ) that the dir names for media and system should be in there ? (they are not after upgrade).

[willem010]

i've checked my config file, and no.. they are not there..

i think this is the cause of a whole heap of issues on the upgrade? (avatar problem etc )

please tell me what the vars should be, and where they should point to i will update manually and see if this solves some issues.

[tgtje]

@willem010 It does NOT give me any troubles as far as i can notice, for not having them present in PRESENT upgrade. These 2 lines are not added, where a fresh install has: $ MEDIA_DIRECTORY = 'e107_media/'; $ SYSTEM_DIRECTORY = 'e107_system/';

Now beware ! having them NOT there does not cause troubles (for me that is during upgrade) The latest upgrade went quite fine. I just stumbled on another thing , but that has to be seen outside the whole upgrade imo. ( a new routine ( ?) for empty installed CORE plugs .. in txt terms explained : see #615 ) Of course i will keep testing.

The question remains for future reference (an update of v2 in future) on an upgraded (org v1) site. Is there a need to have them in there at a certain point in time ? (because they are in the installation as folders present, they are being used.... hard to explain my line of thinking)

[CaMer0n]

They are optional, and only placed there during a fresh install so the person installing knows that they are additional options.