e107inc / e107

e107 Bootstrap CMS (Content Management System) v2 with PHP, MySQL, HTML5, jQuery and Twitter Bootstrap. Issue Discussion Room: https://gitter.im/e107inc/e107
https://e107.org
GNU General Public License v3.0
321 stars 213 forks source link

GDPR checkbox on contact template for bootstrap4 #4318

Closed Jimmi08 closed 2 years ago

Jimmi08 commented 3 years ago

This is just a note (not forget this)

This is already applied in the bootstrap4 theme, but because the contact template is not fully tested, it can't be moved to core BT4 templates yet.

Original code (core/bootstrap3):

    <div class='form-group'><label for='gdpr'>".LANCONTACT_24."</label>
        <div class='checkbox'>
            <label>{CONTACT_GDPR_CHECK} ".LANCONTACT_21."</label>
            <div class='help-block'>{CONTACT_GDPR_LINK}</div> 
        </div>
    </div>

New code:

    {CONTACT_GDPR_CHECK: label=".LANCONTACT_21."}
    <small>{CONTACT_GDPR_LINK}<small>

Result: default bootstrap4: image

image

new core MDB theme: image

image

Jimmi08 commented 3 years ago

Version for bootstrap3:

    <div class='form-group'>    
    {CONTACT_GDPR_CHECK: label=".LANCONTACT_21."}
    <small>{CONTACT_GDPR_LINK}</small>
    </div>
Moc commented 2 years ago

So what do we need to do with this?

Jimmi08 commented 2 years ago

It is too long, I can't remember. There is bootstrap5 already. Closing, if I run in a similar issue, I will create a new one or reopen this.