Membersite only - testing - is this intention

[Jimmi08]

I had fully tested 2.3.1 with the members-only setting (regarding templates)

The only weird thing I noticed was:

1. membersonly.php

• if you disabled login at all user_reg = 2, then there is still a login link to the login page on the members-only splash page (frontpage setting). This could be ok, if login.php would be ok. Maybe link to admin are would be better idea with login disabled.

2. login.php

• if you use the login.php as your frontpage (by mistake, for any reason), login.php is displayed (but you disabled the login option), only the form itself is hidden. And it looks like an error. The login page has to be displayed (otherwise you get neverending redirect), but in this case (user_reg = 2) there should be some message, so the login form doesn't look broken.

3. social login

Why with login disabled there is still social login option?

Just screenshot of my settings (to be sure):

Thanks

[tgtje]

@Jimmi08 ran some thoughts.. Did similar test, i can see what you mean, yes confusing. I do believe it is intentional, keeping in mind (guessing) that a 'total' switch off could/would mean > only.for admin. Having log in redirect to admin is (imo) a no go. (security related). As for social (not implemented in my re-enactment) suggests that social settings in specific cases has to follow the switch. ( or an advanced setting on user registration part ( a switch between visitor awareness, and member only) OR giving a mere new second LAN definition that incorporates mentioning that iff no form is displayed, one is not able to enter (etc).(else iff situation) Just my thoughts on this. Could indeed need a fresh review.

[Jimmi08]

Answered.

[Moc]

This could use some refining.