search

e107inc / e107

e107 Bootstrap CMS (Content Management System) v2 with PHP, MySQL, HTML5, jQuery and Twitter Bootstrap. Issue Discussion Room: https://gitter.im/e107inc/e107
https://e107.org
GNU General Public License v3.0
323 stars 214 forks source link

FR a bit improvement for install other plugins than core from theme manager #4390

Open Jimmi08 opened 3 years ago

Jimmi08 commented 3 years ago

I have set plugin mandatory for the theme in theme.xml

    <plugins>
        <plugin name='jmtheme' url='{e_THEME}cayman/plugins/jmtheme.zip' />
    </plugins>

If that plugin is already in the e107_plugins folder, everything is ok, installation works.

But if not, it looks like this: image

Not clear what to do... link is correct, when you click on it, the zip is downloaded and you can manually upload it.

Any ideas on how to improve this? Maybe button Download if URL is filled and exists? Or maybe direct installation?

Nothing urgent, just it always bothers me with a new theme... so I wanted to note this. I don't have any idea myself how to do this better.

CaMer0n commented 3 years ago

@Jimmi08 e107 has no option for mandatory plugins. A valid theme should always function correctly and look acceptable without requiring a third-party plugin.

Jimmi08 commented 3 years ago

It is not about required plugins but about supported plugins packed with theme.

CaMer0n commented 3 years ago

I have set plugin mandatory for the theme in theme.xml

Themes should not contain zipped plugins.

Jimmi08 commented 3 years ago

It was an example, that URL could go anywhere...

If there is example: <plugin name='gallery' url='core' />

what should be value for non-core plugins then?

Now it is confusing.