library settings is ignored in maintenance state

Jimmi08 commented 3 years ago

Bug Description

When you put the site in a maintenance state, bootstrap is loaded from CDN, not from local sources

How to Reproduce

Steps to reproduce the behavior:

set CDN off
set maintenance
check source code

Expected Behavior

Accept library settings

Screenshots

e107

e107 2.3.0 official

PHP Version

PHP Version 7.4

if you want, you can ask @scupone for an explanation of why this is important. It is mandatory in Germany now, but it is only a question of time to apply in all EU.

tgtje commented 3 years ago

Just mentioning as i do not know where the img (s.c) comes from > bootstrap 3.3.5 afaik this does not belong to v 2.3.0 off. Going back in time (installpacks) last occurance of this netdna on version 2.0.0 were FA has 4.3.0 (v 2.1. has already 3.3.6 and FA 4.5.0) Is the bootstrap theme in use maybe an altered one? On my live (2.3.1 php 7.4.16) reproducing >no issues calls are from web lib folder.

Jimmi08 commented 3 years ago

@tgtje did you set maintenance mode and look as a quest? I tried the bootstrap3 theme too.

I found it, look at sitedown_template:

$SITEDOWN_TABLE .= '
    <html xmlns="http://www.w3.org/1999/xhtml"'.(defined('TEXTDIRECTION') ? ' dir="'.TEXTDIRECTION.'"' : '').(defined('CORE_LC') ? ' xml:lang=\''.CORE_LC.'\'' : '').'>
    <head>
        <meta http-equiv="content-type" content="text/html; charset=utf-8" />
        <meta http-equiv="content-style-type" content="text/css" />
        <link rel="icon" href="{SITEDOWN_FAVICON}" type="image/x-icon" />
        <link rel="shortcut icon" href="{SITEDOWN_FAVICON}" type="image/xicon" />
        <link rel="stylesheet" media="all" property="stylesheet" type="text/css" href="https://netdna.bootstrapcdn.com/bootstrap/3.3.5/css/bootstrap.min.css" />
        <link rel="stylesheet" media="all" property="stylesheet" type="text/css" href="https://netdna.bootstrapcdn.com/font-awesome/4.5.0/css/font-awesome.min.css" />
        <link rel="stylesheet" href="{SITEDOWN_SOCIAL_CSS}" type="text/css" media="all" />
        <link rel="stylesheet" href="{SITEDOWN_E107_CSS}" type="text/css" media="all" />
        <link rel="stylesheet" href="{SITEDOWN_THEME_CSS}" type="text/css" media="all" />
        <title>{SITEDOWN_TABLE_PAGENAME}</title>
        <style type="text/css">
            .img-responsive { display: inline }
        </style>
    </head>

tgtje commented 3 years ago

Ah yes indeed, maybe that was missed during linking newer versions/cdn Since this is 'outbound', no wonder. Hmm you are correct, it only happens when guest on maintenance. Knowing this : a new search reveals this cdn path is also used inside install php line 2866. (why?... it exists nevertheless online)

tgtje commented 3 years ago

Just adding > the external path to older cdn (3.3.5) is logical for install php. Since install is happening and BS should run (displaying), no other files are present yet, being in installment state. No clue however how long that cdn (path) (2015) will be available for future.. EOL was (from bootstrap info) 2019-07-24.

e107inc / e107