e107inc / e107

e107 Bootstrap CMS (Content Management System) v2 with PHP, MySQL, HTML5, jQuery and Twitter Bootstrap. Issue Discussion Room: https://gitter.im/e107inc/e107
https://e107.org
GNU General Public License v3.0
320 stars 214 forks source link

Most Active Threads - in top.php - wrong urls #4772

Open Jimmi08 opened 2 years ago

Jimmi08 commented 2 years ago

Bug Description

Top forum topics are displayed but links to topic and forum are wrong

How to Reproduce

$LINKTOTHREAD = e107::getUrl()->create('forum/thread/view', array('id' =>$row['thread_id'])); //$e107->url->getUrl('forum', 'thread', "func=view&id={$row['thread_id']}");
$LINKTOFORUM = e107::getUrl()->create('forum/forum/view', array('id' => $row['thread_forum_id'])); //$e107->url->getUrl('forum', 'forum', "func=view&id={$row['thread_forum_id']}");

plus pagination is not working (not displayed) there is this legacy code:

$ftotal = $sql->count('forum_thread', '(*)', 'WHEREthread_parent= 0');

Moc commented 1 year ago

Entire /top.php needs a pretty major upgrade, for PHP compatibility as well

Jimmi08 commented 8 months ago

Not needed anymore. It can wait for official/major update.