Closed Deltik closed 10 months ago
Thank you for this @Deltik ! Would you also like to add a test for it in db_VerifyTest::testGetIndex() before I merge the pull-request?
Yep, I'll add a test now, @CaMer0n
Test added, and actually fixed another matching bug when the optional length was omitted: https://github.com/e107inc/e107/compare/ceddd798f04da034735ea340fbf8f733733bb378..b623868756e99b65c0c9f03d09b0f45dad6ef4a4#diff-940e04ed023a2601964002f97da3727414c057256735fc831fbd1fa1aab7703bL1068
Code Climate has analyzed commit b6238687 and detected 0 issues on this pull request.
The test coverage on the diff in this pull request is 100.0% (80% is the threshold).
This pull request will bring the total coverage in the repository to 34.5% (0.0% change).
View more on Code Climate.
Thank you!! 👍
Motivation and Context
Fixes: https://github.com/e107inc/e107/issues/5054
Description
Update the regex in
db_verify::getIndex()
to support the optional parts ofindex_col_name
How Has This Been Tested?
Automated test method:
db_verifyTest::testGetIndexOptionalLengthAndSortOrder()
Types of Changes
Checklist