[Bug]: incorrect use of boostrap class form-inline on user.php page

[Jimmi08]

What e107 version are you using?

v2.3.3

Bug description

Pagination is created this way: echo "<div class='nextprev form-inline'>&nbsp;".$tp->parseTemplate("{NEXTPREV={$parms}}")."</div>";

form-inline shouldn't be used for div class this way. there is next one rendered in template

How to reproduce

See user.php code

Expected behavior

Don't see 2x form-inline rendered in pagination

From docs: Use the .form-inline class to display a series of labels, form controls, and buttons on a single horizontal row. Form controls within inline forms vary slightly from their default states.

Thanks

What browser(s) are you seeing the problem on?

Chrome / Brave

PHP Version

8.1

[Jimmi08]

Result in core bootstrap 5 theme:

bootstrap 4: https://getbootstrap.com/docs/4.4/components/forms/#inline-forms

bootstrap 5 https://getbootstrap.com/docs/5.2/migration/#forms

Bootstrap based classes should be only in templates.

Could be first .form-inline from user.php file removed?

[Moc]

@Jimmi08 I think the change (removing "form-inline" ) should be fine, but the result is still the same in the bootstrap 5 theme as your screenshot. Shouldn't the >> be placed next to the dropdown?

[Jimmi08]

bootstrap5 theme is not correct in this - how to formulate this? - this pagination is not supported in bootstrap5 theme mainly because most of the markup is in core and it has to work for any theme. This is not so easy.

[Moc]

Pffff again with the hardcoded templating. Alright, leaving this open. I am not touching this one.