search

e107inc / pdf

e107 v2 pdf plugin (legacy)
Other
1 stars 3 forks source link

Original TCPDF is still updated.... #6

Open rica-carv opened 3 years ago

rica-carv commented 3 years ago

Original TCPDF is still updated....

Wondering how much of the code here is up to date with original.....

Deltik commented 3 years ago

@tgtje updated tecnickcom/tcpdf to version 6.3.5 recently: https://github.com/e107inc/pdf/pull/5/

I believe the changes make this plugin compatible with PHP 7.4 and PHP 8.0.

tgtje commented 3 years ago

Thank you @Deltik but the committed changes were tested on 7.4 and 8 since pdf (if needed) is being used in Vstore. The changes were just from a few days earlier... (some already changed again after that point, likely indeed to the stricter format for php 8 (as 8 also is an evolving process). Will take a look anyway (but low priority level). At the moment (highest i use 8.0.3) functional.

@rica-carv the changes involve more at the 'bundled changed' tcpdf files, not the e107 'parts' . It basically only differs in the use of coding inside the newer files (deprecated stuff) like use of { ..... } .