search

e107inc / vstore

Simple shopping cart system for e107 v2.x Bootstrap CMS
GNU General Public License v3.0
17 stars 12 forks source link

FA BANK #182

Closed tgtje closed 3 years ago

tgtje commented 3 years ago

Just to be sure, does the fa-bank glyph (inc/adm.conf.gatew. ) and or icon fa-bank (vstore.class) be renamed and which or both ? Internal the image is present, but not on front eg is > fa fa-bank preferable? depending on the used fontawesome build in running system versions?

CaMer0n commented 3 years ago

fa-bank should work with FontAwesome4 and FontAwesome5 since it is passed thru toGlyph() or toIcon(). So, there's nothing to rename there as far as I know.

tgtje commented 3 years ago

Can't find a real 'glitch' that is does not work, In an earlier version it did. (maybe related to something in the lang tests? recompile solves it maybe..) Of course i can replace the icon, that works anyway. Thank you.

CaMer0n commented 3 years ago

@tgtje Which theme are you using?

tgtje commented 3 years ago

Core; basically only BS3 and Voux for testing; trying not to influence strange things which could have impact. (minimum of installed plugins (nearly basic installment).

tgtje commented 3 years ago

Info/reminder : been testing the newer pieces, the fa bank is not displayed in Voux, it does work in BS3. If it concerns.. BS3 overall has nicer view on front than Voux (probably the styling/css), especially the cart (select) window (pop out) eg. placeholder for cust panel, checkout, empty (large and black bg for checkout..(ehh ugly)).

tgtje commented 3 years ago

Just as comment : maybe the issue lies here too : git issue : https://github.com/e107inc/e107/issues/4471 .(+commit) I do need to test it though.

tgtje commented 3 years ago

Before install of latest Gitversion : Theme Voux before After update WITH latest Gitversion (incl. commit) Theme Voux.

after

Concluding : commit solves issue.

CaMer0n commented 3 years ago

Great! Thank you @tgtje !