e107inc / vstore

Simple shopping cart system for e107 v2.x Bootstrap CMS
GNU General Public License v3.0
17 stars 12 forks source link

new feature: field on order #60

Closed kreossino closed 5 years ago

kreossino commented 6 years ago

Hi, could you add three fields on order form? that's for: 1) fiscal code; (codice fiscale) 2) VAT - (Partita Iva) 3) factory (nome azienda) and the captcha code to confirm

SimSync commented 6 years ago

You mean on the summary / order confirmation page or which page exactly? Isn't this something that should be located in the imprint or on the invoice? Do you have an example of it (screenshot or similar)?

edit: Check out the preferences -> email ->Merchant Name/Address. Maybe you can use this field to display the information you're refering to. This field is displayed in the emails and will probably also used on the invoice.

kreossino commented 6 years ago

you could add a field "VAT" and the personal fiscal code with verify (html5) <input type="text" id="iscritti_codicefiscale" pattern="^[a-zA-Z]{6}[0-9]{2}[a-zA-Z][0-9]{2}[a-zA-Z][0-9]{3}[a-zA-Z]$" > (not required)

and in the next step for confirm order a "recaptcha code"

form

Jimmi08 commented 6 years ago

@SimSync for your explanation (If I understand above correctly):

By the way, great work with other things.

SimSync commented 6 years ago

Ah OK. You're talking about the data from the customer, not your merchant data. Well, as written here #63 , i think we need an invoice address and your fields should be included there as it is information about the one who pays the bill and not who receives the items. So once, invoice address gets implemented i'll keep an eye on this.

Jimmi08 commented 6 years ago

@SimSync let this confirm by @kreossino It was just my quess.

SimSync commented 6 years ago

At least on my todo list, this isn't a top priority. So he has time to confirm ... 😄 I think, first storing the recurring customer data for later reference is something that needs to be done before requesting any additional data from the customer.

And by the way: @kreossino You can have the fields already today, by defining the additional checkout fields in the preferences. 😆

kreossino commented 6 years ago

@Jimmi08 @SimSync

the VAT is writted from customer in this form only he buy this merchandise for the company.

the fiscal code is for the identification of customer in Italy this code is a personal data unique code. the customer must indicate this for receive the marchandise.

i must use the "additional checkout fields" ... 👍

Jimmi08 commented 6 years ago

@SimSync See? It depends on country law. So Additional checkout fieds is correct way.

@kreossino Just from curiosity and maybe wrong translation. Really "personal" like not freelancer, not company but normal person? I am looking for how you do this with GDPR. We have this "code" too, but it's the most warded information and if you are asking it from people, you can get to serious troubles.

kreossino commented 6 years ago

@Jimmi08 yes in Italy the fiscal code is necessary for all person and freelances and with a VAT "Partita Iva" for company ( we use this fiscal code for buy medicine, Hospital, documents, shipping merchandise and all other!)

kreossino commented 6 years ago

form1

SimSync commented 6 years ago

I already expect when i wrote about the additional fields that this would come ... 😆 (in future) Maybe this can be solved by modifying the template. At the moment, additional fields are fixed to be rendered after the main fields. I'll open an issue for it to not forget about it.

But I still think, that this should be included (as optional field) into the invoice address. And to position it by modifying the template (if the default position (at the end) doesn't suit).

SimSync commented 6 years ago

There is a webservice of the EU to verify the VAT number: http://ec.europa.eu/taxation_customs/vies/vatRequest.html I found this package on gitgub: https://github.com/DragonBe/vies There are also others. Don't know which is best. But at least there is already something to validate the VAT number.

Moc commented 6 years ago

Tax / VAT Code implemented in #69


I already expect when i wrote about the additional fields that this would come ... laughing (in future) Maybe this can be solved by modifying the template. At the moment, additional fields are fixed to be rendered after the main fields. I'll open an issue for it to not forget about it.

What about this? @SimSync

SimSync commented 6 years ago

Is included in the "tax" update. Vstore now uses this library (https://github.com/dannyvankooten/vat.php) to validate the VAT-ID (EU only).

Moc commented 6 years ago

@SimSync Does it also include the positioning of the additional fields? Ie. not (only) rendered after main fields but positioned as defined by the template?

SimSync commented 6 years ago

Yes, the fields are defined as shortcodes which can be placed as you like in the template.

SimSync commented 6 years ago

But the vat and tax code fields are "fixed" fields that will be rendered on billing address page and not on the shipping address page. The shipping address is now optional.