e14n / databank-mongodb

A databank driver for MongoDB
Apache License 2.0
5 stars 5 forks source link

Regression: $slice limit must be positive #12

Closed strugee closed 6 years ago

strugee commented 7 years ago

In pump.io we have a bug where many (most?) API calls cause "$slice limit must be positive" errors with this Databank driver. You can easily reproduce this by opening the web UI from an instance running this driver and just waiting for the autorefresh. You'll see the error in the console.

I did a bisection and 489016da1410c3c93ed6ed7f486193d9a78e91bb is the commit that regressed this. I've been meaning to confirm this is a bug in the driver, and not merely exposing a preexisting bug in pump, but seeing as I haven't had time and this being a pump bug is unlikely, I'm filing this issue anyway.

See pump-io/pump.io#1287 for where we're tracking this downstream.

evanp commented 6 years ago

I think this is fixed in 1.0.1