search

e2email-org / e2email

E2EMail is a simple Chrome application - a Gmail client that exchanges OpenPGP mail.
Apache License 2.0
806 stars 62 forks source link

Encoding of attachments #11

Closed KamilaHasanbega closed 8 years ago

KamilaHasanbega commented 8 years ago

Right now I'm inserting the attachments as base64 string as per as I understand it, it would work with 7bit content transfer encoding, but I have a few issues I need to clarify.

  1. Is 64bit encoding right in the case, and inputing files as strings or should I go with buffers/other?
  2. Does this work for the android when sending emails (per as I'm aware, Boateng is not doing base64 and I believe we should coordinate so that the messages could be read in every device)?

@kbsriram Please let me know what do you think about this.

koto commented 8 years ago

Content-Tranfer-Encoding base64 for the attachments is a safe choice I think. We can revisit this later.

koto commented 8 years ago

This is safe to close.