e2email-org / e2email

E2EMail is a simple Chrome application - a Gmail client that exchanges OpenPGP mail.
Apache License 2.0
806 stars 62 forks source link

Encrypt attachment #15

Closed KamilaHasanbega closed 8 years ago

KamilaHasanbega commented 8 years ago

Encrypt the attachments and send them (attachment example has dummy values, the fileupload/read in the next CL)

koto commented 8 years ago

LGTM, but @kbsriram should take a look too.

koto commented 8 years ago

The binder icon is too big - here's how it looks like after the CSS changes were merged:

image

koto commented 8 years ago

I've tested the application after the changes, and apart from the comments above, it works OK. It's safe to merge I think, @kbsriram

Kamila, please address the above comments:

koto commented 8 years ago

LGTM. Safe to merge if tests pass.

kbsriram commented 8 years ago

Rebased via 7e34bcd